ci: pin django-common-utils to the ref CI resolves - #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pip install ...django-common-utils.git@devresolves the branch tip at build time, several minutes afterimage-plan.pyresolved that same branch and folded the result into this image's content cache key. A push to common-utils in between yields an image whose contents its own key does not describe — and since the key is what decides reuse, that image is served from cache indefinitely without anything triggering a rebuild.ARG COMMON_UTILS_REF=devlets CI pass the sha it already resolved, so the image holds the commit its key names. The default keepsdocker buildby hand working unchanged.Paired with Space-DF/spacedf-backend#447, which emits
common_utils_refand passes it asCOMMON_UTILS_REF. Order matters: this PR is inert on its own (nothing passes the arg yet), and #447 is inert until this merges and the parent bumps its gitlink for this submodule.